On Wed, Oct 11, 2017 at 11:17:16AM +0000, Wei Yongjun wrote: > In case of error, the function of_graph_get_remote_node() returns NULL > pointer not ERR_PTR(). The IS_ERR() test in the return value check > should be replaced with NULL test.. > > Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx> Reviewed-by: Sean Paul <seanpaul@xxxxxxxxxxxx> > --- > drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c > index e27352c..527aa58 100644 > --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c > +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c > @@ -236,8 +236,8 @@ static int kirin_drm_platform_probe(struct platform_device *pdev) > } > > remote = of_graph_get_remote_node(np, 0, 0); > - if (IS_ERR(remote)) > - return PTR_ERR(remote); > + if (!remote) > + return -ENODEV; > > drm_of_component_match_add(dev, &match, compare_of, remote); > of_node_put(remote); > > > -- Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
