On Mon, Sep 25, 2017 at 08:19:12PM +0100, Chris Wilson wrote: > Quoting ville.syrjala@xxxxxxxxxxxxxxx (2016-04-01 19:48:50) > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > Eliminate the duplicate code for pipe timing readout in > > intel_crtc_mode_get() by using the functions we use for the normal state > > readout. > > > > v2: Store dotclock in adjusted_mode instead of the final mode > > > > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx > > Cc: Rob Kramer <rob@xxxxxxxxxxxxxxxxxx> > > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx> > > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Thanks for the review. Patches pushed to dinq. > > Fixes a pipe-state warn for me, > Tested-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> However, now that I look at the code again I'm not 100% sure why this fixed anything. The readout still seems to fail at fully populating the mode flags. I'll post a more thorough solution that simply calls the normal state readout hooks for the crtc and encoder... -- Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
