Re: [PATCH] drm/rockchip: add PINCTRL dependency for LVDS

[姚智情 <mark.yao@xxxxxxxxxxxxxx>]

Acked-by: Mark Yao <mark.yao@xxxxxxxxxxxxxx>

Thanks for the fix, and sorry for that, I'm in holidays now，currently has no environment to do the patch pushed.

I'll be back next week and do this patch push.

Thanks

Mark.

On 2017年10月5日周四 19:10 Arnd Bergmann <arnd@xxxxxxxx> wrote:

The new driver fails to build when CONFIG_PINCTRL is disabled:

drivers/gpu/drm/rockchip/rockchip_lvds.c: In function 'rockchip_lvds_grf_config':
drivers/gpu/drm/rockchip/rockchip_lvds.c:229:39: error: dereferencing pointer to incomplete type 'struct dev_pin_info'
   if (lvds->pins && !IS_ERR(lvds->pins->default_state))

This adds the respective Kconfig dependency.

Fixes: 34cc0aa25456 ("drm/rockchip: Add support for Rockchip Soc LVDS")
Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
---
 drivers/gpu/drm/rockchip/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
index 0c31f0a27b9c..3c70c6224bd2 100644
--- a/drivers/gpu/drm/rockchip/Kconfig
+++ b/drivers/gpu/drm/rockchip/Kconfig
@@ -60,6 +60,7 @@ config ROCKCHIP_INNO_HDMI
 config ROCKCHIP_LVDS
        bool "Rockchip LVDS support"
        depends on DRM_ROCKCHIP
+       depends on PINCTRL
        help
          Choose this option to enable support for Rockchip LVDS controllers.
          Rockchip rk3288 SoC has LVDS TX Controller can be used, and it
--
2.9.0

--

Ｍark Yao 姚智情   

Rockchip 福州瑞芯微电子有限公司

Fuzhou Headquarters

Addr:No.21 Building, A District, Fuzhou

Software Park, 89 Soft Avenue, Tongpan Road, 

Gulou District, Fuzhou (350003)

地址:福建省福州市铜盘路软件大道89号软件园A区21号楼 (350003)

Tel:（86-0591）83991906 - 8296 

E-mail:mark.yao@xxxxxxxxxxxxxx 

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel