Re: [PATCH] sync_file: Return consistent status in SYNC_IOC_FILE_INFO

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 04, 2017 at 11:43:23AM +0100, Chris Wilson wrote:
> In hindsight, having both the per-fence and global variable be called
> info was a mistake. Certainly made this diff a little harder to parse
> than required!

I agree, I had to re-read the code a few times to find & fix the bug.

> Personally I would have set info.status directly rather than add a new
> fences_status. But that's immaterial to the bug fix,

I can clean that up if there is a need for a v2.

> Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

Thanks!

John

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux