tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next
head: ea0eda9a882b5df33808dbd85bd64376ed187618
commit: 38d794ae060df6cf5bf2caa4742e379a45bcc018 [1170/1179] drm/amd/powerplay: fixed wrong return vaule on error
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 6.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 38d794ae060df6cf5bf2caa4742e379a45bcc018
# save the attached .config to linux build tree
make.cross ARCH=ia64
Note: the radeon-alex/amd-staging-drm-next HEAD ea0eda9a882b5df33808dbd85bd64376ed187618 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/vega10_powertune.c: In function 'vega10_enable_didt_config':
>> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/vega10_powertune.c:1246:40: error: passing argument 1 of 'vega10_enable_smc_features' from incompatible pointer type [-Werror=incompatible-pointer-types]
result = vega10_enable_smc_features(hwmgr->smumgr, true, data->smu_features[GNLD_DIDT].smu_feature_bitmap);
^~~~~
In file included from drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/vega10_powertune.c:27:0:
drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/vega10_smumgr.h:60:5: note: expected 'struct pp_hwmgr *' but argument is of type 'struct pp_smumgr *'
int vega10_enable_smc_features(struct pp_hwmgr *hwmgr,
^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/vega10_powertune.c: In function 'vega10_disable_didt_config':
drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/vega10_powertune.c:1293:40: error: passing argument 1 of 'vega10_enable_smc_features' from incompatible pointer type [-Werror=incompatible-pointer-types]
result = vega10_enable_smc_features(hwmgr->smumgr, false, data->smu_features[GNLD_DIDT].smu_feature_bitmap);
^~~~~
In file included from drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/vega10_powertune.c:27:0:
drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/vega10_smumgr.h:60:5: note: expected 'struct pp_hwmgr *' but argument is of type 'struct pp_smumgr *'
int vega10_enable_smc_features(struct pp_hwmgr *hwmgr,
^~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/vega10_enable_smc_features +1246 drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/vega10_powertune.c
1207
1208 int vega10_enable_didt_config(struct pp_hwmgr *hwmgr)
1209 {
1210 int result = 0;
1211 struct vega10_hwmgr *data = (struct vega10_hwmgr *)(hwmgr->backend);
1212
1213 if (data->smu_features[GNLD_DIDT].supported) {
1214 if (data->smu_features[GNLD_DIDT].enabled)
1215 PP_DBG_LOG("[EnableDiDtConfig] Feature DiDt Already enabled!\n");
1216
1217 switch (data->registry_data.didt_mode) {
1218 case 0:
1219 result = vega10_enable_cac_driving_se_didt_config(hwmgr);
1220 PP_ASSERT_WITH_CODE((0 == result), "[EnableDiDt] Attempt to enable DiDt Mode 0 Failed!", return result);
1221 break;
1222 case 2:
1223 result = vega10_enable_psm_gc_didt_config(hwmgr);
1224 PP_ASSERT_WITH_CODE((0 == result), "[EnableDiDt] Attempt to enable DiDt Mode 2 Failed!", return result);
1225 break;
1226 case 3:
1227 result = vega10_enable_se_edc_config(hwmgr);
1228 PP_ASSERT_WITH_CODE((0 == result), "[EnableDiDt] Attempt to enable DiDt Mode 3 Failed!", return result);
1229 break;
1230 case 1:
1231 case 4:
1232 case 5:
1233 result = vega10_enable_psm_gc_edc_config(hwmgr);
1234 PP_ASSERT_WITH_CODE((0 == result), "[EnableDiDt] Attempt to enable DiDt Mode 5 Failed!", return result);
1235 break;
1236 case 6:
1237 result = vega10_enable_se_edc_force_stall_config(hwmgr);
1238 PP_ASSERT_WITH_CODE((0 == result), "[EnableDiDt] Attempt to enable DiDt Mode 6 Failed!", return result);
1239 break;
1240 default:
1241 result = -EINVAL;
1242 break;
1243 }
1244
1245 if (0 == result) {
> 1246 result = vega10_enable_smc_features(hwmgr->smumgr, true, data->smu_features[GNLD_DIDT].smu_feature_bitmap);
1247 PP_ASSERT_WITH_CODE((0 == result), "[EnableDiDtConfig] Attempt to Enable DiDt feature Failed!", return result);
1248 data->smu_features[GNLD_DIDT].enabled = true;
1249 }
1250 }
1251
1252 return result;
1253 }
1254
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
