Re: [PATCH 1/3] drm/syncobj: extract two helpers from drm_syncobj_create

["Zhou, David(ChunMing)" <David1.Zhou@xxxxxxx>]

Could you test and review it? On hand, I have no env.

Regards,
David Zhou

发自坚果 Pro

Marek Ol?醟 <maraeo@xxxxxxxxx> 于 2017年9月30日 下午11:56写道：

The idea sounds good.

Marek

On Sat, Sep 30, 2017 at 3:55 AM, Chunming Zhou <zhoucm1@xxxxxxx> wrote:
> My mean is like the attached, I revert part of yours.
>
> Regards,
>
> David zhou
>
>
>
> On 2017年09月29日 22:15, Marek Olšák wrote:
>>
>> On Fri, Sep 29, 2017 at 4:13 PM, Marek Olšák <maraeo@xxxxxxxxx> wrote:
>>>
>>> On Fri, Sep 29, 2017 at 4:44 AM, Chunming Zhou <zhoucm1@xxxxxxx> wrote:
>>>>
>>>>
>>>> On 2017年09月13日 04:42, Marek Olšák wrote:
>>>>>
>>>>> From: Marek Olšák <marek.olsak@xxxxxxx>
>>>>>
>>>>> For amdgpu.
>>>>>
>>>>> drm_syncobj_create is renamed to drm_syncobj_create_as_handle, and new
>>>>> helpers drm_syncobj_create and drm_syncobj_get_handle are added.
>>>>>
>>>>> Signed-off-by: Marek Olšák <marek.olsak@xxxxxxx>
>>>>> ---
>>>>>    drivers/gpu/drm/drm_syncobj.c | 49
>>>>> +++++++++++++++++++++++++++++++++++++++----
>>>>>    include/drm/drm_syncobj.h     |  4 ++++
>>>>>    2 files changed, 49 insertions(+), 4 deletions(-)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/drm_syncobj.c
>>>>> b/drivers/gpu/drm/drm_syncobj.c
>>>>> index 0422b8c..0bb1741 100644
>>>>> --- a/drivers/gpu/drm/drm_syncobj.c
>>>>> +++ b/drivers/gpu/drm/drm_syncobj.c
>>>>> @@ -262,8 +262,14 @@ void drm_syncobj_free(struct kref *kref)
>>>>>    }
>>>>>    EXPORT_SYMBOL(drm_syncobj_free);
>>>>>    -static int drm_syncobj_create(struct drm_file *file_private,
>>>>> -                             u32 *handle, uint32_t flags)
>>>>
>>>> You can add a new parameter for passing dma fence, then in patch3, you
>>>> can
>>>> directly use it for AMDGPU_FENCE_TO HANDLE_GET_SYNCOBJ.
>>>>
>>>> otherwise the set looks good to me.
>>>
>>> Sorry I just pushed this.
>>
>> Actually, you commented on a deleted line. The function already has
>> dma_fence among the parameters.
>>
>> Marek
>
>

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel