Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On 09/26/17 11:30, Aishwarya Pant wrote:
> For maintaining consistency with kernel coding style replace
> reference/unreference in ref counting functions with get/put.
>
> The following cocci script was used to generate the tilcdc patch:
>
> @@
> expression ex;
> @@
>
> (
> -drm_framebuffer_unreference(ex);
> +drm_framebuffer_put(ex);
> |
> -drm_dev_unref(ex);
> +drm_dev_put(ex);
> |
> -drm_framebuffer_reference(ex);
> +drm_framebuffer_get(ex);
> )
>
> Signed-off-by: Aishwarya Pant <aishpant@xxxxxxxxx>
Acked-by: Jyri Sarha <jsarha@xxxxxx>
I guess this should go in via drm-misc at the same time with
"drm: introduce drm_dev_{get/put} functions".
Best regards,
Jyri
> ---
> No changes in v2
>
> drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 6 +++---
> drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
> index 406fe45..d2589f310 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
> @@ -75,7 +75,7 @@ static void unref_worker(struct drm_flip_work *work, void *val)
> struct drm_device *dev = tilcdc_crtc->base.dev;
>
> mutex_lock(&dev->mode_config.mutex);
> - drm_framebuffer_unreference(val);
> + drm_framebuffer_put(val);
> mutex_unlock(&dev->mode_config.mutex);
> }
>
> @@ -456,7 +456,7 @@ static void tilcdc_crtc_set_mode(struct drm_crtc *crtc)
>
> set_scanout(crtc, fb);
>
> - drm_framebuffer_reference(fb);
> + drm_framebuffer_get(fb);
>
> crtc->hwmode = crtc->state->adjusted_mode;
> }
> @@ -633,7 +633,7 @@ int tilcdc_crtc_update_fb(struct drm_crtc *crtc,
> return -EBUSY;
> }
>
> - drm_framebuffer_reference(fb);
> + drm_framebuffer_get(fb);
>
> crtc->primary->fb = fb;
> tilcdc_crtc->event = event;
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index b0d70f9..74276ef 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -225,7 +225,7 @@ static void tilcdc_fini(struct drm_device *dev)
>
> pm_runtime_disable(dev->dev);
>
> - drm_dev_unref(dev);
> + drm_dev_put(dev);
> }
>
> static int tilcdc_init(struct drm_driver *ddrv, struct device *dev)
>
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
