On Mon, Sep 25, 2017 at 09:01:38AM +0000, vathsala nagaraju wrote: > On Monday 25 September 2017 01:53 PM, Jani Nikula wrote: > > On Sat, 23 Sep 2017, vathsala nagaraju <vathsala.nagaraju@xxxxxxxxx> wrote: > > Add defines for dpcd register 2009 (synchronization latency > in sink). > > Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > CC: Puthikorn Voravootivat <puthik@xxxxxxxxxxxx> > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@xxxxxxxxx> > --- > include/drm/drm_dp_helper.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h > index 11c39f1..846004e6 100644 > --- a/include/drm/drm_dp_helper.h > +++ b/include/drm/drm_dp_helper.h > @@ -735,6 +735,9 @@ > # define DP_PSR_SINK_INTERNAL_ERROR 7 > # define DP_PSR_SINK_STATE_MASK 0x07 > > +#define DP_SINK_SYNCHRONIZATION_LATENCY 0x2009 > +# define DP_MAX_RESYNC_FRAME_CNT_MASK 0xf > > For the DP spec, please don't invent the names, use the ones from the > spec. At most drop excess stuff from the end. > > In edp 1.4b spec , the register name 2009 is "DEBUG 0 SYNCHRONIZATION LATENCY SINK " and > bit 0:3 "MAX RE-SYNC FRAME COUNT" probably he meant something like: # define DP_SYNCHRONIZATION_LATENCY_IN_SINK 0x2009 # define DP_MAX_RESYNC_FRAME_COUNT_MASK 0xf but he is the best one to confirm that... > > > #define DP_SYNCHRONIZATION_LATENCY_IN_SINK > # define DP_MAX_RESYNC_FRAME_COUNT_SHIFT > # define DP_MAX_RESYNC_FRAME_COUNT_MASK > > And while at it, please add the full register contents. > > BR, > Jani. > > > + > #define DP_RECEIVER_ALPM_STATUS 0x200b /* eDP 1.4 */ > # define DP_ALPM_LOCK_TIMEOUT_ERROR (1 << 0) > > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
