Re: [patch] vmwgfx: return -EFAULT instead of number of bytes remaining

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/18/2011 08:09 AM, Dan Carpenter wrote:
The intent here was to return an error code, but instead the code
returns the number of bytes remaining (that weren't copied).

Signed-off-by: Dan Carpenter<dan.carpenter@xxxxxxxxxx>

Reviewed-by: Thomas Hellstrom <thellstrom@xxxxxxxxxx>


diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
index 97f23ab..3f63435 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
@@ -150,6 +150,7 @@ int vmw_present_ioctl(struct drm_device *dev, void *data,
  	ret = copy_from_user(clips, clips_ptr, num_clips * sizeof(*clips));
  	if (ret) {
  		DRM_ERROR("Failed to copy clip rects from userspace.\n");
+		ret = -EFAULT;
  		goto out_no_copy;
  	}

@@ -241,6 +242,7 @@ int vmw_present_readback_ioctl(struct drm_device *dev, void *data,
  	ret = copy_from_user(clips, clips_ptr, num_clips * sizeof(*clips));
  	if (ret) {
  		DRM_ERROR("Failed to copy clip rects from userspace.\n");
+		ret = -EFAULT;
  		goto out_no_copy;
  	}


_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux