Re: [PATCH 3/3] drm/panel: Add Ilitek ILI9322 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Aug 13, 2017 at 1:44 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:

> This adds support for the Ilitek ILI9322 QVGA (320x240)
> TFT panel driver.
>
> This panel driver supports serial or parallel RGB or
> YUV input and also ITU-T BT.656 input streams.
>
> The controller is combined with a physical panel and
> configured through the device tree.
>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
Any opinion on this panel driver?

As background, I also found that similar hardware is handled by
backlight drivers:
drivers/video/backlight/ili9320.c
drivers/video/backlight/ili922x.c

For example in ili922x_display_init() in the last file, the stuff
we handle with properly documented DT properties is instead
handled with hard-coded magic numbers.

Overall backlight is a real bad fit for this hardware, since,
yeah you got it, it's not just about backlight, much more about
panel driving in general.

I guess the platforms using these "backlight" drivers should
be augmented to use this driver or a sibling of it, and its
DT bindings if/when their respective target systems get
migrated to DT.

Since Ben worked on the old drivers I toss him in for
review so I can get some kind of opinion on this.
Ben: tell me if you want me to resend the whole set.

Yours,
Linus Walleij
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux