[radeon-alex:amd-staging-drm-next 1046/1053] drivers/gpu//drm/amd/lib/chash.c:213:51: warning: self-comparison always evaluates to false

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next
head:   dcae401d111324489c066aa57ed9c77b97b475f9
commit: 18c073719186a393b41715686cf95175c58919df [1046/1053] drm/amd: Closed hash table with low overhead
config: i386-allyesconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        git checkout 18c073719186a393b41715686cf95175c58919df
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/gpu//drm/amd/lib/chash.c: In function 'chash_iter_relocate':
>> drivers/gpu//drm/amd/lib/chash.c:213:51: warning: self-comparison always evaluates to false [-Wtautological-compare]
     BUG_ON(src.table->key_size != src.table->key_size);
                                                      ^~
   drivers/gpu//drm/amd/lib/chash.c:214:53: warning: self-comparison always evaluates to false [-Wtautological-compare]
     BUG_ON(src.table->value_size != src.table->value_size);
                                                        ^~

vim +213 drivers/gpu//drm/amd/lib/chash.c

   209	
   210	static void chash_iter_relocate(struct chash_iter dst, struct chash_iter src)
   211	{
   212		BUG_ON(src.table == dst.table && src.slot == dst.slot);
 > 213		BUG_ON(src.table->key_size != src.table->key_size);
   214		BUG_ON(src.table->value_size != src.table->value_size);
   215	
   216		if (dst.table->key_size == 4)
   217			dst.table->keys32[dst.slot] = src.table->keys32[src.slot];
   218		else
   219			dst.table->keys64[dst.slot] = src.table->keys64[src.slot];
   220	
   221		if (dst.table->value_size)
   222			memcpy(chash_iter_value(dst), chash_iter_value(src),
   223			       dst.table->value_size);
   224	
   225		chash_iter_set_valid(dst);
   226		chash_iter_set_invalid(src);
   227	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux