On Tue, Sep 12, 2017 at 09:34:08AM +0200, Maciej Purski wrote:
> Add HDMI and Sil9234 MHL converter to Trats2 board.
> Following in SoC devices have been enabled:
> - HDMI (HDMI signal encoder),
> - Mixer (video buffer scanout device),
> - I2C_5 bus (used for HDMI DDC)
> - I2C_8 bus (used for HDMI_PHY control).
>
> Based on previous work by:
> Tomasz Stanislawski <t.stanislaws@xxxxxxxxxxx>
>
> Signed-off-by: Maciej Purski <m.purski@xxxxxxxxxxx>
> ---
> arch/arm/boot/dts/exynos4412-trats2.dts | 112 ++++++++++++++++++++++++++++++++
> 1 file changed, 112 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
> index 35e9b94..742e02a 100644
> --- a/arch/arm/boot/dts/exynos4412-trats2.dts
> +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
> @@ -18,6 +18,7 @@
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/clock/maxim,max77686.h>
> +#include <dt-bindings/pinctrl/samsung.h>
>
> / {
> model = "Samsung Trats 2 based on Exynos4412";
> @@ -97,6 +98,34 @@
> gpio = <&gpj0 5 GPIO_ACTIVE_HIGH>;
> enable-active-high;
> };
> +
> + vsil12: voltage-regulator-6 {
> + compatible = "regulator-fixed";
> + regulator-name = "VSIL_1.2V";
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1200000>;
> + gpio = <&gpl0 4 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + vin-supply = <&buck7_reg>;
> + };
> +
> + vcc33mhl: voltage-regulator-7 {
> + compatible = "regulator-fixed";
> + regulator-name = "VCC_3.3_MHL";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpio = <&gpl0 4 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> + vcc18mhl: voltage-regulator-8 {
> + compatible = "regulator-fixed";
> + regulator-name = "VCC_1.8_MHL";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + gpio = <&gpl0 4 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> };
>
> gpio-keys {
> @@ -229,6 +258,36 @@
> };
> };
>
> + i2c-mhl {
> + compatible = "i2c-gpio";
> + gpios = <&gpf0 4 GPIO_ACTIVE_HIGH &gpf0 6 GPIO_ACTIVE_HIGH>;
Please split it like in other nodes:
gpios = <...>, <...>
AFAIR they should work the same so keep it consistent.
Rest looks good but the bindings have to be accepted first.
Best regards,
Krzysztof
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
