On Wed, Sep 13, 2017 at 01:02:14PM +0530, Allen Pais wrote:
> Signed-off-by: Allen Pais <allen.lkml@xxxxxxxxx>
Hi Allen
Although correct, if you look higher up the call chain, this appears
to be not so useful.
rlb_initialize() is only called by bond_alb_initialize(), and it
propagates the -1. That is only called by bond_open() with:
if (bond_alb_initialize(bond, (BOND_MODE(bond) == BOND_MODE_ALB)))
return -ENOMEM;
So you might want to also modify this code, to return the return
value, rather than use the hard coded ENOMEM.
Since you code is OK as far as it goes:
Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
Andrew
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
