On 11.09.2017 15:54, Tobias Jakobi wrote:
> Hello Andrzej,
>
> just did a quick test and looks good so far. One thing I noticed is that
> compared to Daniel's approach you just manipulate HDMI_TG_HACT_{ST,SZ}_L,
> instead of HDMI_TG_VACT_SZ_L + HDMI_TG_HACT_{ST,SZ}_L. I just wanted to make
> sure that on the HDMI level, this does the same thing?
With Daniel's patch 1st line and the last column are missing.
With this patch 1st line is distorted, last column is OK, IMO better result.
Another alternative I see is to hide 1st line and make all columns OK,
but I am not really convinced to it, but it is just my feelings :)
Btw, I have also played with 800x600, but I was not able to find good
timings - HBLANK is too small.
There are also other resolutions which one can try to fix. Especially
after adding more clocks to HDMI-PHY.
Regards
Andrzej
>
> I'll try to do a proper review tomorrow.
>
> I also noticed that I have another patch by Daniel in my tree, which, together
> with the quirk, enables 1366x768@60Hz. Going to send it shortly, since it could
> probably go along with this series.
>
> With best wishes,
> Tobias
>
>
>
> Andrzej Hajda wrote:
>> Hi all,
>>
>> This patchset does two main things:
>> - removes mode limitation for Exynos542x chips, multiple modes were filtered
>> out due to lack of HW version checking code,
>> - enables two modes on older chips, thanks to quirk found by Daniel Drake,
>> and published by Tobias Jakobi [1][2].
>> Beside this it consolidates the code and performs multiple cleanups.
>>
>> [1]: http://www.spinics.net/lists/linux-samsung-soc/msg24617.html
>> [2]: https://www.spinics.net/lists/dri-devel/msg150906.html
>>
>> Regards
>> Andrzej
>>
>>
>> Andrzej Hajda (10):
>> drm/exynos/mixer: abstract out output mode setup code
>> drm/exynos/mixer: move mode commit to enable callback
>> drm/exynos/mixer: move resolution configuration to single function
>> drm/exynos/mixer: fix mode validation code
>> drm/exynos/mixer: remove mixer_resources sub-structure
>> drm/exynos/hdmi: remove redundant mode field
>> drm/exynos: add mode_fixup callback to exynos_drm_crtc_ops
>> drm/exynos/mixer: pass actual mode on MIXER to encoder
>> drm/exynos/hdmi: quirk for support mode timings conversion
>> drm/exynos/mixer: enable support for 1024x768 and 1280x1024 modes
>>
>> drivers/gpu/drm/exynos/exynos_drm_crtc.c | 15 +
>> drivers/gpu/drm/exynos/exynos_drm_drv.h | 3 +
>> drivers/gpu/drm/exynos/exynos_hdmi.c | 49 ++--
>> drivers/gpu/drm/exynos/exynos_mixer.c | 452 +++++++++++++++----------------
>> 4 files changed, 265 insertions(+), 254 deletions(-)
>>
>
>
>
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
