Re: [PATCH] qxl: fix primary surface handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[CC-ing Gabriel]

Hi Gerd,

On 11 September 2017 at 10:39, Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote:
> The atomic conversion of the qxl driver didn't got the primary surface
> handling completely right.  It works in the common simple cases, but
> fails for example when changing the display resolution using xrandr or
> in multihead setups.
>
> The rules are simple:  There is one primary surface.  Before defining a
> new one you have to destroy the old one.
>
> This patch makes qxl_primary_atomic_update() destroy the primary surface
> before defining a new one.  It fixes is_primary flag updates.  It adds
> is_primary checks so we don't try to update the primary surface in case
> it already has the state we want it being in.
>
Please include a fixes tag alongside the bug reports (if it addresses
both that is). Adding cross-references is very beneficial.

Fixes: 3538e80a869b ("drm: qxl: Atomic phase 1: Implement mode_set_nofb")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102338
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=196777


-Emil
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux