Linus Walleij <linus.walleij@xxxxxxxxxx> writes: > This replaces the custom connector in the PL111 with the > panel bridge helper. > > This works nicely for all standard panels, but since there > are several PL11x-based systems that will need to use the dumb > VGA connector bridge we use drm_of_find_panel_or_bridge() > and make some headroom for dealing with bridges that are > not panels as well, and drop a TODO in the code. > > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > +out_bridge: > + if (panel) > + drm_panel_bridge_remove(bridge); > + else > + drm_bridge_remove(bridge); Drop the "else drm_bridge_remove(bridge)" here and in the hunk below -- that unregisters the bridge driver entirely, rather than unreferencing it from your driver (there's no refcounting to be done). With that change, Reviewed-by: Eric Anholt <eric@xxxxxxxxxx> > out_config: > drm_mode_config_cleanup(dev); > finish: > @@ -236,6 +250,10 @@ static int pl111_amba_remove(struct amba_device *amba_dev) > drm_dev_unregister(drm); > if (priv->fbdev) > drm_fbdev_cma_fini(priv->fbdev); > + if (priv->panel) > + drm_panel_bridge_remove(priv->bridge); > + else > + drm_bridge_remove(priv->bridge); > drm_mode_config_cleanup(drm); > drm_dev_unref(drm); > > -- > 2.13.5
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
