Re: [PATCH 1/4] drm/bridge: adv7511: Properly update EDID when no EDID was found

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 09/05/2017 10:14 PM, John Stultz wrote:
On Tue, Sep 5, 2017 at 5:10 AM, Lars-Peter Clausen <lars@xxxxxxxxxx> wrote:
Currently adv7511_get_modes() bails out early when no EDID could be
retrieved. This leaves the previous EDID in place, which is typically not
the intended behavior and might confuse applications. Instead the EDID
should be cleared when no EDID could be retrieved.

All functions that are called after the EDID check handle the case where
the EDID is NULL just fine and exhibit the expected behavior, so just drop
the check.

Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>

No objections from me. Ran these on my HiKey board ontop of Linus's
HEAD, and everything seemed ok.

So for the whole patchset:
Tested-by: John Stultz <john.stultz@xxxxxxxxxx>

The set looks good to me too. I'll queue it to drm-misc-next in a few days.

Thanks,
Archit


thanks
-john


--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux