On Fri, Sep 1, 2017 at 10:23 AM, Emil Velikov <emil.l.velikov@xxxxxxxxx> wrote:
>>Eric E:
>>> +struct pl111_variant_data pl110_variant = {
>>
>> I think this (and `pl111_variant` below) can be `static const`, right?
>>
> Static - yes, const - I don't think so.
> Struct amba_id::data lacks the constness, so the const qualifier will
> get discarded.
I fixed it with a (void*) cast so we can have it right in the driver.
> In practise everyone considers/uses ::data as const, so that could be
> tweaked with separate patch.
I think it is not necessarily possible to make that const since the amba_id
is used in several dynamically generated board files. But I may
be wrong.
Yours,
Linus Walleij
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
