On Sat, Aug 19, 2017 at 11:58:17PM +0530, Arvind Yadav wrote: > i2c_device_id are not supposed to change at runtime. All functions > working with i2c_device_id provided by <linux/i2c.h> work with > const i2c_device_id. So mark the non-const structs as const. All applied. btw I think this isn't your first series, and we're trying to keep some of the trivial mistakes around in drm, as an easy way for newbies to get into the subsystem with their first patch. We'd like more regular contributors to tackle some of the more involved cleanup tasks, which should also be more valuable to the subsystem: file:///home/daniel/linux/src/Documentation/output/gpu/todo.html#todo Cheers, Daniel > > Arvind Yadav (3): > [PATCH 1/3] drm: i2c: ch7006: constify i2c_device_id > [PATCH 2/3] drm: i2c: sil164: constify i2c_device_id > [PATCH 3/3] drm: i2c: tda998x: constify i2c_device_id > > drivers/gpu/drm/i2c/ch7006_drv.c | 2 +- > drivers/gpu/drm/i2c/sil164_drv.c | 2 +- > drivers/gpu/drm/i2c/tda998x_drv.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > -- > 2.7.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
