Re: [PATCH 12/14] drm/exynos: mic: clean up drm_bridge_add call

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




2017년 07월 05일 18:14에 Archit Taneja 이(가) 쓴 글:
> 
> 
> On 07/05/2017 02:35 PM, Inki Dae wrote:
>>
>>
>> 2017년 07월 05일 18:00에 Archit Taneja 이(가) 쓴 글:
>>>
>>>
>>> On 07/03/2017 02:12 PM, Inki Dae wrote:
>>>> This patch removes unnecessary checking of return value.
>>>>
>>>> Ps. this patch depends on below one,
>>>>      http://www.spinics.net/lists/dri-devel/msg145687.html
>>>
>>> Will this one^ go via the exynos pull req or drm-misc? If there won't
>>> be any conflicts, we could get both the patches through drm-misc to
>>> keep things simple.
>>
>> exynos pull it would be better. I will pick this up. :)
> 
> If patch # 1/14 goes through drm-misc, and the exynos patch goes through
> exynos pull, the drm-misc branch would break. That's the reason I
> preferred the exynos patches to go via misc.

Sorry for late. I missed checking your comment. Sorry for this.
As you commented, I left Acked-by so that this patch series can go to mainline through misc without build break.

Thanks,
Inki Dae

> 
> Thanks,
> Archit
> 
>>
>> Thanks,
>> Inki Dae
>>
>>>
>>> Archit
>>>
>>>>
>>>> Signed-off-by: Inki Dae <inki.dae@xxxxxxxxxxx>
>>>> ---
>>>>    drivers/gpu/drm/exynos/exynos_drm_mic.c | 6 +-----
>>>>    1 file changed, 1 insertion(+), 5 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
>>>> index 5ea6e3d..07bd7fc 100644
>>>> --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
>>>> +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
>>>> @@ -458,11 +458,7 @@ static int exynos_mic_probe(struct platform_device *pdev)
>>>>        mic->bridge.funcs = &mic_bridge_funcs;
>>>>        mic->bridge.of_node = dev->of_node;
>>>>    -    ret = drm_bridge_add(&mic->bridge);
>>>> -    if (ret) {
>>>> -        DRM_ERROR("mic: Failed to add MIC to the global bridge list\n");
>>>> -        return ret;
>>>> -    }
>>>> +    drm_bridge_add(&mic->bridge);
>>>>          pm_runtime_enable(dev);
>>>>   
>>>
> 
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux