Hi Noralf,
Thank you for the patch.
On Thursday 17 Aug 2017 18:21:30 Noralf Trønnes wrote:
> Reject mapping an imported dma-buf since is's an invalid use-case.
>
> Cc: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Cc: Sean Paul <seanpaul@xxxxxxxxxxxx>
> Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
> Signed-off-by: Noralf Trønnes <noralf@xxxxxxxxxxx>
> ---
> drivers/gpu/drm/drm_gem.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
> index ad4e9cf..8da5801 100644
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -333,6 +333,12 @@ int drm_gem_dumb_map_offset(struct drm_file *file,
> struct drm_device *dev, if (!obj)
> return -ENOENT;
>
> + /* Don't allow imported objects to be mapped */
> + if (obj->import_attach) {
> + ret = -EINVAL;
> + goto out;
> + }
> +
Wouldn't it be better to move this check to drm_gem_create_mmap_offset_size()
to reject mapping of all imported dmabuf, not just the ones associated with
dumb buffers ?
> ret = drm_gem_create_mmap_offset(obj);
> if (ret)
> goto out;
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
