Re: [PATCH v2 07/19] drm/cirrus: Use the drm_driver.dumb_destroy default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Den 16.08.2017 09.38, skrev Daniel Vetter:
On Sun, Aug 06, 2017 at 05:40:56PM +0200, Noralf Trønnes wrote:
drm_gem_dumb_destroy() is the drm_driver.dumb_destroy default,
so no need to set it.

Cc: Dave Airlie <airlied@xxxxxxxxxx>
Cc: Gerd Hoffmann <kraxel@xxxxxxxxxx>
Signed-off-by: Noralf Trønnes <noralf@xxxxxxxxxxx>
---
  drivers/gpu/drm/cirrus/cirrus_drv.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/cirrus/cirrus_drv.c b/drivers/gpu/drm/cirrus/cirrus_drv.c
index 910c300..69c4e35 100644
--- a/drivers/gpu/drm/cirrus/cirrus_drv.c
+++ b/drivers/gpu/drm/cirrus/cirrus_drv.c
@@ -142,7 +142,6 @@ static struct drm_driver driver = {
  	.gem_free_object_unlocked = cirrus_gem_free_object,
  	.dumb_create = cirrus_dumb_create,
  	.dumb_map_offset = cirrus_dumb_mmap_offset,
I think the cirrus mmap_offset could be replaced too, it's just written
slightly differently from what I can tell with the separate helper
function.

Emil asked about the same, but cirrus uses ttm_buffer_object.vma_node
to get the offset and not drm_gem_object.vma_node.
He couldn't answer whether they're the same vma_node or not.

Noralf.


-Daniel

-	.dumb_destroy = drm_gem_dumb_destroy,
  };
static const struct dev_pm_ops cirrus_pm_ops = {
--
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux