On Sun, Aug 06, 2017 at 05:41:01PM +0200, Noralf Trønnes wrote:
> drm_gem_dumb_destroy() is the drm_driver.dumb_destroy default,
> so no need to set it.
>
> Cc: Rob Clark <robdclark@xxxxxxxxx>
> Signed-off-by: Noralf Trønnes <noralf@xxxxxxxxxxx>
> ---
> drivers/gpu/drm/msm/msm_drv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> index f49f6ac..b0129e7 100644
> --- a/drivers/gpu/drm/msm/msm_drv.c
> +++ b/drivers/gpu/drm/msm/msm_drv.c
> @@ -832,7 +832,6 @@ static struct drm_driver msm_driver = {
> .gem_vm_ops = &vm_ops,
> .dumb_create = msm_gem_dumb_create,
> .dumb_map_offset = msm_gem_dumb_map_offset,
This one is a bit more complicated because it throws it's own locking in
for fun. But the vma manger already has all the locking it needs, so this
is redundant. We could first simplify msm_gem_mmap_offset and drop the
locking, racy check and just call the vma offset helper directly, then
replace the dumb mmap function with the generic one.
-Daniel
> - .dumb_destroy = drm_gem_dumb_destroy,
> .prime_handle_to_fd = drm_gem_prime_handle_to_fd,
> .prime_fd_to_handle = drm_gem_prime_fd_to_handle,
> .gem_prime_export = drm_gem_prime_export,
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
