On Fri, Oct 07, 2011 at 10:58:13AM +0200, Thomas Hellstrom wrote: > Oh, and one more style comment below: > > On 08/07/2011 10:39 PM, Marek Olšák wrote: > > > > +enum ttm_buffer_usage { > > + TTM_USAGE_READ = 1, > > + TTM_USAGE_WRITE = 2, > > + TTM_USAGE_READWRITE = TTM_USAGE_READ | TTM_USAGE_WRITE > > +}; > > > > > > Please don't use enums for bit operations. Now I'm curious. Why not? -- Ville Syrjälä syrjala@xxxxxx http://www.sci.fi/~syrjala/ _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel