Am 15.08.2017 um 13:23 schrieb Chris Wilson:
Quoting Christian König (2017-08-13 14:04:29)
Am 11.08.2017 um 19:01 schrieb Chris Wilson:
This is an illegal scenario, to free the fence whilst there are pending
callbacks. Currently, we emit a WARN and then cast aside the callbacks
leaving them dangling. Alternatively, we could set an error on the fence
and then signal fence so that any dependency chains from the fence can
be tidied up, and if they care they can check for the error.
The question is whether or not the cure is worse than the disease
(premature fence signaling is never pretty).
Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Not sure if -EDEADLK is the best error code, but in general the approach
sounds like the least evil to me.
EDEADLK felt appropriate since that was the situation that I expect might
arise, well livelock.
-ENXIO? That seems a reasonable alternative.
-ENODEV?
The classic -ENOTTY?
No strong opinion either. For now I think we should just stick with
-EDEADLK.
We would need something like -EHUMAN, because in this particular case
the human who wrote the code has messed up the reference counting.
Christian.
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
