I didn't mean to add libdrm, sorry, there is a separate change for that. I'll double check and test the drivers that don't implement the virtual.
Thanks for the quick reply!
-j
On Tue, Aug 8, 2017 at 4:50 PM, Dave Airlie <airlied@xxxxxxxxx> wrote:
On 9 August 2017 at 09:42, Joe Kniss <djmk@xxxxxxxxxxxx> wrote:
> Because all drivers currently use gem objects for framebuffer planes,
> the virtual create_handle() is not required. This change adds a
> struct drm_gem_object *gems[4] field to drm_framebuffer and removes
> create_handle() function pointer from drm_framebuffer_funcs. The
> corresponding *_create_handle() function is removed from each driver.
>
> In many cases this change eliminates a struct *_framebuffer object,
> as the only need for the derived struct is the addition of the gem
> object pointer.
Why the libdrm in the tag? this isn't for libdrm.
This will break drivers that don't current implement the virtual at all.
I think vwmgfx.
The current code checks if the virtual is there before callng it, this code
just calls the gem code always.
Dave.
| Dr. Joe Michael Kniss | | Google ChromeOS | | djmk@google.com | | 1-801-898-7977 |
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
