On 02/07/17 09:19, Arvind Yadav wrote:
> dma_buf_ops are not supposed to change at runtime. All functions
> working with dma_buf_ops provided by <linux/dma-buf.h> work with
> const dma_buf_ops. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 1240 112 0 1352 548 drivers/gpu/drm/omapdrm/omap_gem_dmabuf.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 1352 0 0 1352 548 drivers/gpu/drm/omapdrm/omap_gem_dmabuf.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>
> ---
> drivers/gpu/drm/omapdrm/omap_gem_dmabuf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem_dmabuf.c b/drivers/gpu/drm/omapdrm/omap_gem_dmabuf.c
> index 0dbe030..a03bc36 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem_dmabuf.c
> +++ b/drivers/gpu/drm/omapdrm/omap_gem_dmabuf.c
> @@ -154,7 +154,7 @@ static int omap_gem_dmabuf_mmap(struct dma_buf *buffer,
> return omap_gem_mmap_obj(obj, vma);
> }
>
> -static struct dma_buf_ops omap_dmabuf_ops = {
> +static const struct dma_buf_ops omap_dmabuf_ops = {
> .map_dma_buf = omap_gem_map_dma_buf,
> .unmap_dma_buf = omap_gem_unmap_dma_buf,
> .release = omap_gem_dmabuf_release,
>
Thanks! I've picked this and the 3 other constifying patches to omapdrm
tree.
Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
