On Thu, Aug 3, 2017 at 5:52 PM, Cihangir Akturk <cakturk@xxxxxxxxx> wrote: > On Thu, Aug 03, 2017 at 02:49:03PM +0200, Daniel Vetter wrote: >> On Thu, Aug 03, 2017 at 03:26:01PM +0300, Jani Nikula wrote: >> > On Thu, 03 Aug 2017, Cihangir Akturk <cakturk@xxxxxxxxx> wrote: >> > > drm_*_reference() and drm_*_unreference() functions are just >> > > compatibility alias for drm_*_get() and drm_*_put() adn should not be >> > > used by new code. So convert all users of compatibility functions to use >> > > the new APIs. >> > >> > Please include the cocci script in the commit message. If you didn't use >> > cocci, you should check it out! :) >> >> Yeah I assume you've created these with spatch/cocci, not with your own >> script. I trust cocci a lot more than any kind of scripting, and the >> coccie patch is already in there kernel (the commits you've cited in the >> cover letter contain it iirc). > > I wrote a simple shell script, which you can see in the cover letter. > But you are right I take function list from scripts/coccinelle/api/drm-get-put.cocci > file. > > Daniel Should I use coccinelle to generate patches and resend a v2? > If so, do i need to include reviewed-by and acked-by tags to patches myself? I think regenerating the patches using cocci would be great, I trust cocci a lot more than random scripts. And cocci is a great tool to learn anyway (if you don't know it yet). If the resulting patches match, you can keep the r-b/a-b tags for v2. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
