Re: [PATCH 5/6] drm/rockchip: vop: report error when check resource error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi mark,

在 2017/7/31 17:49, Mark Yao 写道:
The user would be confused while facing a error commit without
any error report.

Signed-off-by: Mark Yao <mark.yao@xxxxxxxxxxxxxx>
---
  drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index fa0d9f7..999c2e0 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
@@ -674,8 +674,10 @@ static int vop_plane_atomic_check(struct drm_plane *plane,
  	 * Src.x1 can be odd when do clip, but yuv plane start point
  	 * need align with 2 pixel.
  	 */
-	if (is_yuv_support(fb->format->format) && ((state->src.x1 >> 16) % 2))
+	if (is_yuv_support(fb->format->format) && ((state->src.x1 >> 16) % 2)) {
+		DRM_ERROR("Invalid Source: Yuv format not support odd xpos\n");
  		return -EINVAL;
+	}
return 0;
  }


Reviewed-by: Sandy huang <sandy.huang@xxxxxxxxxxxxxx>

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux