On Mon, 3 Jul 2017 21:53:54 +0530 Arvind Yadav <arvind.yadav.cs@xxxxxxxxx> wrote: > drm_plane_helper_funcs and drm_plane_funcsare not supposed to change > at runtime. All functions working with drm_plane_helper_funcs and > drm_plane_funcs work with const. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 6072 596 0 6668 1a0c atmel_hlcdc_plane.o > > File size After adding 'const': > text data bss dec hex filename > 6218 436 0 6654 19fe atmel_hlcdc_plane.o > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx> Applied to drm-misc-next. Thanks, Boris > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > index 29cc10d..ea72e1f 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > @@ -911,7 +911,7 @@ void atmel_hlcdc_plane_irq(struct atmel_hlcdc_plane *plane) > desc->name); > } > > -static struct drm_plane_helper_funcs atmel_hlcdc_layer_plane_helper_funcs = { > +static const struct drm_plane_helper_funcs atmel_hlcdc_layer_plane_helper_funcs = { > .atomic_check = atmel_hlcdc_plane_atomic_check, > .atomic_update = atmel_hlcdc_plane_atomic_update, > .atomic_disable = atmel_hlcdc_plane_atomic_disable, > @@ -1020,7 +1020,7 @@ static void atmel_hlcdc_plane_atomic_destroy_state(struct drm_plane *p, > kfree(state); > } > > -static struct drm_plane_funcs layer_plane_funcs = { > +static const struct drm_plane_funcs layer_plane_funcs = { > .update_plane = drm_atomic_helper_update_plane, > .disable_plane = drm_atomic_helper_disable_plane, > .set_property = drm_atomic_helper_plane_set_property, _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel