On 01/08/17 13:28, Mark Brown wrote:
On Tue, Aug 01, 2017 at 01:24:03PM +0100, Srinivas Kandagatla wrote:
On 01/08/17 09:42, Arnaud Pouliquen wrote:
On 08/01/2017 12:49 AM, srinivas.kandagatla@xxxxxxxxxx wrote:
I already used ADV7513 and i did not observe this limitation.
I had a look to ADV7533 data-sheet. it should support 32 and 64 bits I2S
ADV7511_REG_AUDIO_CFG3(0x14) register definition in datasheet and the code
in this driver suggest that It only supports 16Bit and 24Bit samples.
The amount of data it pays attention to in the frame is not the same as
the size of the frame.
I agree.
format bus, with 16 or 24 bits precision sample. So it should support
SNDRV_PCM_FMTBIT_S32_LE and SNDRV_PCM_FMTBIT_S32_BE
As example, if you configure bus in Left justified format with 24 bits
sample length, 32 bits application samples should be truncated to 24
bits samples at ADV7533 I2S interface level (LSB dropped).
May be we can do that to make the user happy but isn't this just truncate
the resolution to 24Bit then?
And it's a false indication that we are supporting 32bit samples.
Which am not very happy with.
This is what the sample_bits field in the DAI structure is for.ya.
But still reporting that driver supports 32 bit samples when it does not
really support all 32 bits, is kinda misleading to user.
Isn't it?
And the driver would be end up with hacked up code for each case.
--srini
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
