On Tue, Jul 25, 2017 at 10:25 AM, Jon Hunter <jonathanh@xxxxxxxxxx> wrote:
>
> On 21/07/17 17:13, Arnd Bergmann wrote:
>> Without CONFIG_OF, we can run into a build error:
>>
>> drivers/gpu/drm/tegra/dpaux.c:378:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function); did you mean 'pinconf_generic_params'?
>> .dt_node_to_map = pinconf_generic_dt_node_to_map_group,
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> pinconf_generic_params
>> drivers/gpu/drm/tegra/dpaux.c:379:17: error: 'pinconf_generic_dt_free_map' undeclared here (not in a function); did you mean 'pinconf_generic_params'?
>>
>> This adds an explicit dependency.
>>
>> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>> ---
>> drivers/gpu/drm/tegra/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/tegra/Kconfig b/drivers/gpu/drm/tegra/Kconfig
>> index 2db29d67193d..dc58ab140151 100644
>> --- a/drivers/gpu/drm/tegra/Kconfig
>> +++ b/drivers/gpu/drm/tegra/Kconfig
>> @@ -3,6 +3,7 @@ config DRM_TEGRA
>> depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
>> depends on COMMON_CLK
>> depends on DRM
>> + depends on OF
>> select DRM_KMS_HELPER
>> select DRM_MIPI_DSI
>> select DRM_PANEL
>
> Thanks Arnd. I am curious if it can still fail if PINCTRL is not
> selected in whatever config you are using?
I have not run into other those problems in many randconfig builds.
Looking at the driver now, I see it has an "#ifdef CONFIG_GENERIC_PINCONF"
to handle that case.
Arnd
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
