Noralf Trønnes <noralf@xxxxxxxxxxx> writes: > Almost everyone did end up using GEM as bo, so this adds defaults > for the drm_driver.dumb_destroy and drm_driver.dumb_map_offset > callbacks. > > Signed-off-by: Noralf Trønnes <noralf@xxxxxxxxxxx> > --- > drivers/gpu/drm/drm_dumb_buffers.c | 26 ++++++++++++++++++-------- > 1 file changed, 18 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/drm_dumb_buffers.c b/drivers/gpu/drm/drm_dumb_buffers.c > index 10307cc..cd68ab4 100644 > --- a/drivers/gpu/drm/drm_dumb_buffers.c > +++ b/drivers/gpu/drm/drm_dumb_buffers.c > @@ -24,6 +24,7 @@ > */ > > #include <drm/drmP.h> > +#include <drm/drm_gem.h> > > #include "drm_crtc_internal.h" > > @@ -42,9 +43,10 @@ > * create dumb buffers suitable for scanout, which can then be used to create > * KMS frame buffers. > * > - * To support dumb objects drivers must implement the &drm_driver.dumb_create, > - * &drm_driver.dumb_destroy and &drm_driver.dumb_map_offset operations. See > - * there for further details. > + * To support dumb objects drivers must implement the &drm_driver.dumb_create > + * operation. &drm_driver.dumb_destroy defaults to drm_gem_dumb_destroy() if > + * not set and &drm_driver.dumb_map_offset operations to s/operations/default/ I think Other than that, patch 1-2 are: Reviewed-by: Eric Anholt <eric@xxxxxxxxxx> Thanks for working on these cleanups!
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
