On Thu, 20 Jul 2017 06:17:58 +0200, Dave Airlie wrote: > > On 19 July 2017 at 00:43, Takashi Iwai <tiwai@xxxxxxx> wrote: > > From: Egbert Eich <eich@xxxxxxx> > > > > Add two more models G200_PCI and G200 for PCI device IDs 0x520 and > > 0x521, respectively. They need to retrieve the reference clock and > > pclk min/max values from BIOS, and set up the PLLs accordingly. > > Is there any advantage in supporting these GPUs? Heh, you are suggesting that KMS support has no merit? ;) > The main idea of the mgag200 driver is for unaccelerated support for > server GPUs. > > These look like ancient desktop GPUs, I can't imagine we see them > shipping in any modern server hw, and also I'm guessing they had basic > 3D accel features that the old UMS mga driver would "support". Right, but I thought we want to move on to support KMS. If there is another big picture to glean such leftover devices, I'd love to follow that. But this patch itself is simple enough and it can't regress the other existing mgag200 devices, so it's still worth to consider, IMO. thanks, Takashi _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
