On Tue, 2017-07-18 at 17:25 +0300, Paul Kocialkowski wrote:
> This adds the connector name when printing a debug message about the DP
> link training result. It is useful to figure out what connector is
> failing when multiple DP connectors are used.
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@xxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c
> index b79c1c0e404c..05907fa8a553 100644
> --- a/drivers/gpu/drm/i915/intel_dp_link_training.c
> +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c
> @@ -321,12 +321,16 @@ intel_dp_start_link_train(struct intel_dp *intel_dp)
> if (!intel_dp_link_training_channel_equalization(intel_dp))
> goto failure_handling;
>
> - DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane count = %d",
> + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training Passed at Link Rate = %d, Lane count = %d",
> + intel_connector->base.base.id,
> + intel_connector->base.name,
> intel_dp->link_rate, intel_dp->lane_count);
> return;
>
> failure_handling:
> - DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane count = %d",
> + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training failed at link rate = %d, lane count = %d",
> + intel_connector->base.base.id,
> + intel_connector->base.name,
> intel_dp->link_rate, intel_dp->lane_count);
> if (!intel_dp_get_link_train_fallback_values(intel_dp,
> intel_dp->link_rate,
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@xxxxxxxxx>
The choice of upper v/s lower case letters in these debug messages is a
bit odd.
Passed/failed
Link rate/link rate
Lane count/lane count
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
