On Sun, Jul 16, 2017 at 12:43 AM, Mike Galbraith <efault@xxxxxx> wrote: > On Sat, 2017-07-15 at 14:52 -0400, Ilia Mirkin wrote: >> >> OK, so this issue appears to be that we're calling >> drm_crtc_vblank_off() on a crtc for which vblank is already disabled. >> My guess is that this happens because the crtc is disabled. >> >> Not sure what the proper check is to see if vblanks are already disabled... > > Seems so, the below shut up suspend for both 8600 GT and GTX 980. The modeset done by drm_atomic_helper_suspend (called previously to that *_fini) should already take care of disabling vblanks, I think. So the vblank_off calls can just be done when we're not doing an atomic modeset [drm_drv_uses_atomic_modeset(dev)] -- this is all very confusing since pre-nv50 uses legacy modesets, while nv50+ has been moved to atomic, but they share a bunch of helpers =/ _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
