On Thu, Sep 29, 2011 at 06:09:41PM -0700, Keith Packard wrote: > On eDP, DDC requires panel power, but turning that on uses the panel > power sequencing timing values fetch from the DPCD data. > > Signed-off-by: Keith Packard <keithp@xxxxxxxxxx> Can't really check more than what the patch does what it claims to do, so a weak: Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> And a small question from the clueless: With your patch intel_dp_i2c_auch_ch checks whether panel or vdd is on, but I don't see where we turn that on and the drm dp i2c core seems to do a few transactions on setup time. Should we splatter a vdd_on/off around the i2c_init or is the panel guaranteed to have power at init time? -Daniel -- Daniel Vetter Mail: daniel@xxxxxxxx Mobile: +41 (0)79 365 57 48 _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel