On Thu, Sep 29, 2011 at 06:09:34PM -0700, Keith Packard wrote: > This masks out all interrupts and ack's any pending ones at IRQ > uninstall time to make sure we don't receive any unexpected interrupts > later on. > > Signed-off-by: Keith Packard <keithp@xxxxxxxxxx> > --- > drivers/gpu/drm/i915/i915_irq.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index c22823b..adeab2a 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -2044,6 +2044,10 @@ static void ironlake_irq_uninstall(struct drm_device *dev) > I915_WRITE(GTIMR, 0xffffffff); > I915_WRITE(GTIER, 0x0); > I915_WRITE(GTIIR, I915_READ(GTIIR)); > + > + I915_WRITE(SDEIMR, 0xffffffff); > + I915_WRITE(SDEIER, 0x0); > + I915_WRITE(SDEIIR, I915_READ(SDEIIR)); > } Shouldn't we mask/ack south DE irqs before before we mask DE irqs to avoid races, i.e. move this new code up? -Daniel -- Daniel Vetter Mail: daniel@xxxxxxxx Mobile: +41 (0)79 365 57 48 _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
