On 5 July 2017 at 22:31, Li, Samuel <Samuel.Li@xxxxxxx> wrote: >> - above all, as-is make check will fail > Right, I did not check that. > >> - keeping the radeon API symmetrical to the amdgpu one would a good idea > The issue is Radeon does not have a struct similar to amdgpu_device_handle. Attach it to analogous primitive? > I think the current radeon API is simpler. Maybe a follow up change can change amdgpu's API similar to radeon. > Exposing 3 entry points instead of 1 is _not_simpler. Also you cannot change the existing API, since it also breaks the ABI. Leading to crash/cause memory corruption when using existing binaries. >> - is adding yet another header really justified? > radeon_asic_id.h? That is going to be used by ddx/mesa. > Where it's used is orthogonal. You don't need a separate _public_ header for nearly every entry point ;-) Thanks Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
