Re: [PATCH libdrm 1/2] util: move some files to an ASIC neutral directory.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 30 June 2017 at 20:24, Samuel Li <Samuel.Li@xxxxxxx> wrote:

Commit message should explain why we want this - aka "Will be reused
in radeon with a later commit"

> Change-Id: Iac1c4870253e8b8860a61b7cf175e7a25cc95921
> Signed-off-by: Samuel Li <Samuel.Li@xxxxxxx>
> ---
>  Makefile.sources         |  10 +-
>  amdgpu/Makefile.am       |   3 +-
>  amdgpu/Makefile.sources  |   7 +-
>  amdgpu/amdgpu_asic_id.c  | 219 ---------------------------
>  amdgpu/amdgpu_device.c   |   7 +-
>  amdgpu/amdgpu_internal.h |  11 +-
>  amdgpu/util_hash.c       | 387 -----------------------------------------------
>  amdgpu/util_hash.h       | 107 -------------
>  amdgpu/util_hash_table.c | 262 --------------------------------
>  amdgpu/util_hash_table.h |  73 ---------
>  util/util_asic_id.c      | 217 ++++++++++++++++++++++++++
>  util/util_asic_id.h      |  39 +++++
>  util/util_hash.c         | 387 +++++++++++++++++++++++++++++++++++++++++++++++
>  util/util_hash.h         | 107 +++++++++++++
>  util/util_hash_table.c   | 262 ++++++++++++++++++++++++++++++++
>  util/util_hash_table.h   |  73 +++++++++
>  16 files changed, 1102 insertions(+), 1069 deletions(-)
>  delete mode 100644 amdgpu/amdgpu_asic_id.c
>  delete mode 100644 amdgpu/util_hash.c
>  delete mode 100644 amdgpu/util_hash.h
>  delete mode 100644 amdgpu/util_hash_table.c
>  delete mode 100644 amdgpu/util_hash_table.h
>  create mode 100644 util/util_asic_id.c
>  create mode 100644 util/util_asic_id.h
>  create mode 100644 util/util_hash.c
>  create mode 100644 util/util_hash.h
>  create mode 100644 util/util_hash_table.c
>  create mode 100644 util/util_hash_table.h
>
Please generate patches which move files around with git format-patch -M.


> diff --git a/Makefile.sources b/Makefile.sources
> index 10aa1d0..f2b0ec6 100644
> --- a/Makefile.sources
> +++ b/Makefile.sources
> @@ -10,12 +10,18 @@ LIBDRM_FILES := \
>         libdrm_macros.h \
>         libdrm_lists.h \
>         util_double_list.h \
> -       util_math.h
> +       util_math.h \
> +       util/util_asic_id.c \
> +       util/util_hash.c \
> +       util/util_hash_table.c
>
>  LIBDRM_H_FILES := \
>         libsync.h \
>         xf86drm.h \
> -       xf86drmMode.h
> +       xf86drmMode.h \
> +       util/util_asic_id.h \
> +       util/util_hash.h \
> +       util/util_hash_table.h
>
The "H_FILES" are installed, which we don't want to do here. Please
move them to LIBDRM_FILES above.


Thanks
Emil
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux