On Tue, Jul 4, 2017 at 5:40 PM, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote: >> + mutex_lock(&fb_helper->dev->mode_config.mutex); >> drm_enable_connectors(fb_helper, enabled); >> + if (drm_fb_helper_probe_connector_modes(fb_helper, width, height) == 0) > > This changes the order of these two functions calls. Looks to me like > drm_fb_helper_probe_connector_modes() updates connector->status, and > drm_enable_connectors() depends on it. So either these shouldn't get > reordered or there's some not immediately obvious reason why that's OK. I think some rebase fail somewhere ... this should indeed not get reordered. Thanks for spotting. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel