On Mon, Jul 03, 2017 at 06:53:38PM +0200, Daniel Vetter wrote: > On Mon, Jul 03, 2017 at 04:43:35PM +0300, ville.syrjala@xxxxxxxxxxxxxxx wrote: > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > We will never add private objects with a NULL state into the atomic > > state, hence checking for that is pointless. > > > > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@xxxxxxxxx> > > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > > For patches 1&2, feels a bit overengineered to me, I think the other one > was simpler. I had to do the same thing for private objects, hence I figure why not share the code and avoid putting in slightly different bugs for different type object. > Not objecting, you just need to find someone else to > like&review it. > -Daniel > > > --- > > drivers/gpu/drm/drm_atomic.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c > > index 1663ec3626a1..a61e396b11a8 100644 > > --- a/drivers/gpu/drm/drm_atomic.c > > +++ b/drivers/gpu/drm/drm_atomic.c > > @@ -1019,8 +1019,7 @@ drm_atomic_get_private_obj_state(struct drm_atomic_state *state, void *obj, > > struct __drm_private_objs_state *arr; > > > > for (i = 0; i < state->num_private_objs; i++) > > - if (obj == state->private_objs[i].obj && > > - state->private_objs[i].obj_state) > > + if (obj == state->private_objs[i].obj) > > return state->private_objs[i].obj_state; > > > > num_objs = state->num_private_objs + 1; > > -- > > 2.13.0 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@xxxxxxxxxxxxxxxxxxxxx > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch -- Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
