On Thu, Jun 29, 2017 at 12:59 PM, Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> wrote: >> @@ -2538,6 +2563,12 @@ int drm_fb_helper_hotplug_event(struct drm_fb_helper *fb_helper) >> return 0; >> >> mutex_lock(&fb_helper->lock); >> + if (fb_helper->deferred_setup) { >> + err = __drm_fb_helper_initial_config(fb_helper, >> + fb_helper->preferred_bpp); > Maybe rename this function to *_and_unlock? I had to read this code twice to make sure it works as intended. :) If this is the official suffix for trickery like this I can do - I already asked on irc what it should be called :-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel