Hi Laurent, On Wed, 2017-06-28 at 00:16 +0300, Laurent Pinchart wrote: > The CRTC helper .commit() operation is legacy code, the atomic helpers > prefer the .enable() operation. As the arcpgu driver implements the > .enable() operation, .commit() is never used and can be removed. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/arc/arcpgu_crtc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/arc/arcpgu_crtc.c b/drivers/gpu/drm/arc/arcpgu_crtc.c > index 611af74a31c0..51745608e09d 100644 > --- a/drivers/gpu/drm/arc/arcpgu_crtc.c > +++ b/drivers/gpu/drm/arc/arcpgu_crtc.c > @@ -164,7 +164,6 @@ static const struct drm_crtc_helper_funcs arc_pgu_crtc_helper_funcs = { > .enable = arc_pgu_crtc_enable, > .disable = arc_pgu_crtc_disable, > .prepare = arc_pgu_crtc_disable, > - .commit = arc_pgu_crtc_enable, > .atomic_begin = arc_pgu_crtc_atomic_begin, > }; Acked-by: Alexey Brodkin <abrodkin@xxxxxxxxxxxx> _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel