On Thu, Jun 22, 2017 at 11:42 AM, Sharma, Shashank <shashank.sharma@xxxxxxxxx> wrote: >> You should explain in 1-2 sentences what exactly this function does, and >> when a driver should use it. Just documenting the input/output stuff >> doesn't make the kerneldoc all that useful. > > Did you miss the first 3 lines above ? > "get the most suitable output. > Find the best suitable HDMI output considering source capability, sink > capability and user's choice (expressed in form of drm property)" > Or you mean that's not enough ? Indeed. Usually I sort the paramaters first, then the text. There should also be an empty line before the text starts. Would be great if you can do that since you'll respin anyway. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
