Re: [PATCH] drm: sti: sti_hqvdp: Fix compilation warning.

[Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>]

Hi,

On Tuesday 20 June 2017 04:59 PM, Benjamin Gaignard wrote:

2017-06-20 6:55 GMT+02:00 Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>:

Replace '%d' by '%zu' and '%lu' to fix the following compilation warning:-

drivers/gpu/drm/sti/sti_hqvdp.c: In function ‘sti_hqvdp_start_xp70’:
drivers/gpu/drm/sti/sti_hqvdp.c:925:3: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ [-Wformat=]
   DRM_ERROR("Invalid firmware size (%d)\n", firmware->size);
   ^
drivers/gpu/drm/sti/sti_hqvdp.c:930:3: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘long unsigned int’ [-Wformat=]
   DRM_ERROR("Invalid fmw structure (%d+%d+%d+%d+%d != %d)\n",
   ^
drivers/gpu/drm/sti/sti_hqvdp.c:930:3: warning: format ‘%d’ expects argument of type ‘int’, but argument 9 has type ‘size_t’ [-Wformat=]

I do not manage to reproduce the warnings on my side so I will merge
this patch yet.

Please look include/linux/firmware.h file. You can find declaration of struct firmware {  size_t size; ...}
type of 'size' variable is size_t. so it should be '%zu'.

Regards
Benjamin

Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>
---
 drivers/gpu/drm/sti/sti_hqvdp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c
index 66f8431..267d816 100644
--- a/drivers/gpu/drm/sti/sti_hqvdp.c
+++ b/drivers/gpu/drm/sti/sti_hqvdp.c
@@ -922,12 +922,12 @@ static void sti_hqvdp_start_xp70(struct sti_hqvdp *hqvdp)

        header = (struct fw_header *)firmware->data;
        if (firmware->size < sizeof(*header)) {
-               DRM_ERROR("Invalid firmware size (%d)\n", firmware->size);
+               DRM_ERROR("Invalid firmware size (%zu)\n", firmware->size);
                goto out;
        }
        if ((sizeof(*header) + header->rd_size + header->wr_size +
                header->pmem_size + header->dmem_size) != firmware->size) {
-               DRM_ERROR("Invalid fmw structure (%d+%d+%d+%d+%d != %d)\n",
+               DRM_ERROR("Invalid fmw structure (%lu+%d+%d+%d+%d != %zu)\n",
                          sizeof(*header), header->rd_size, header->wr_size,
                          header->pmem_size, header->dmem_size,
                          firmware->size);
--
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel