On Tue, Jun 20, 2017 at 11:48:05AM +0200, Boris Brezillon wrote: > On Tue, 20 Jun 2017 11:42:28 +0200 > Daniel Vetter <daniel.vetter@xxxxxxxx> wrote: > > > It's not obvious that when using the new color manager stuff you still > > need to wire up the legacy helper to get legacy LUT support. Improve > > this with more links. drm_crtc_funcs->gamma_set already explains this > > properly. > > > > Cc: Peter Rosin <peda@xxxxxxxxxx> > > Cc: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx> > > Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx> Thanks for the review, applied. -Daniel > > > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx> > > --- > > drivers/gpu/drm/drm_color_mgmt.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_color_mgmt.c b/drivers/gpu/drm/drm_color_mgmt.c > > index 3eda500fc005..fe0982708e95 100644 > > --- a/drivers/gpu/drm/drm_color_mgmt.c > > +++ b/drivers/gpu/drm/drm_color_mgmt.c > > @@ -128,6 +128,9 @@ EXPORT_SYMBOL(drm_color_lut_extract); > > * optional. The gamma and degamma properties are only attached if > > * their size is not 0 and ctm_property is only attached if has_ctm is > > * true. > > + * > > + * Drivers should use drm_atomic_helper_legacy_gamma_set() to implement the > > + * legacy &drm_crtc_funcs.gamma_set callback. > > */ > > void drm_crtc_enable_color_mgmt(struct drm_crtc *crtc, > > uint degamma_lut_size, > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
