Smaller scope reduces visibility of variable and makes usage of uninitialized variable less possible. --- drivers/gpu/drm/drm_atomic.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index f32506a..ea5a9a7 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -108,10 +108,11 @@ struct drm_atomic_state * drm_atomic_state_alloc(struct drm_device *dev) { struct drm_mode_config *config = &dev->mode_config; - struct drm_atomic_state *state; if (!config->funcs->atomic_state_alloc) { - state = kzalloc(sizeof(*state), GFP_KERNEL); + struct drm_atomic_state *state + = kzalloc(sizeof(*state), GFP_KERNEL); + if (!state) return NULL; if (drm_atomic_state_init(dev, state) < 0) { -- 2.10.0 --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel