On Wed, 21 Sep 2011 09:47:59 +0530, Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> wrote: > I'm worried this makes our PPS even more complex and hard to follow. > I'd rather see VDD AUX applied only when we need it (dpms, mode set and > detect; for hotplug we can assume the panel is alive) and that we > carefully disable it after waiting for a time after a full PPS on > sequence when doing a mode set or dpms on command. You'll see the fairly long list of places where VDD AUX is needed in my other reply; a couple of them could probably be fixed by moving the PPS calls around. > Having all the power stuff at the highest levels would be clearest I > think. Yes, making it cleaner would help a ton. There are some basic problems with the DRM API that make this hard though -- intel_dp_prepare may not ever be followed by a call to intel_dp_commit. That's why I had the VDD AUX stuff get turned off by a delayed work proc instead. Also, leaving VDD AUX high after EDID is fetched means that we can start the mode setting immediately, rather than having to wait for the power-off/power-on delay (which is really long). What we could do is force VDD AUX off after the panel gets turned on; that would ensure that turning the panel off would actually turn the power off, rather than having VDD stay high for some time after that. -- keith.packard@xxxxxxxxx
Attachment:
pgpz4OsVN8cKS.pgp
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
