Arguments of the .is_addr_reg() are swapped in the definition of the function, that is quite confusing. Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx> Reviewed-by: Erik Faye-Lund <kusmabite@xxxxxxxxx> Reviewed-by: Mikko Perttunen <mperttunen@xxxxxxxxxx> --- include/linux/host1x.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/host1x.h b/include/linux/host1x.h index 71a34774b56a..561d6bb6580d 100644 --- a/include/linux/host1x.h +++ b/include/linux/host1x.h @@ -233,7 +233,7 @@ struct host1x_job { u8 *gather_copy_mapped; /* Check if register is marked as an address reg */ - int (*is_addr_reg)(struct device *dev, u32 reg, u32 class); + int (*is_addr_reg)(struct device *dev, u32 class, u32 reg); /* Check if class belongs to the unit */ int (*is_valid_class)(u32 class); -- 2.13.0 _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel